[CI] Consolidate style, Serge review and GPU test bots under @diffusers-bot - #14623
Conversation
sayakpaul
left a comment
There was a problem hiding this comment.
Thanks! Can we keep the logic of the individual jobs in their own files and invoke them from diffusers_bot.yml? Otherwise, it's just one big file to maintain which could be burdensome.
Additionally, could we share the auth step? I don't think it would hurt to unify the permissions across all the three jobs?
| # @diffusers-bot style run `make style && make quality` and push the fixes to the PR branch | ||
| # @diffusers-bot review request a Serge AI review (also works from an inline review comment) | ||
| # @diffusers-bot pytest <args> run `pytest <args>` on a GPU runner, e.g. |
There was a problem hiding this comment.
But the comment is /diffusers-bot though.
There was a problem hiding this comment.
Right. We would change to using @ mention for all the bots?
There was a problem hiding this comment.
But the problem there is we could have diffusers-bot as an actual GitHub username and the interference would be messy there. So, maybe it's better to stick to /diffusers-bot.
| github.event_name == 'issue_comment' && | ||
| github.event.issue.pull_request && | ||
| github.event.issue.state == 'open' && | ||
| contains(github.event.comment.body, '@diffusers-bot review') && |
There was a problem hiding this comment.
For Serge, we use @askserge, though. I am guessing that should still work?
'. + {installation: {id: $iid}} | .comment.body |= sub("@diffusers-bot review"; "@askserge")' ?
|
@sayakpaul split out the workflows, they all have |
sayakpaul
left a comment
There was a problem hiding this comment.
The separation looks really nice, thanks! I think it still makes sense to continue to use /diffusers-bot and not @diffusers-bot, though.
See: https://github.com/huggingface/diffusers/pull/14623/changes#r3962237359
|
@sayakpaul Updated to use /diffusers-bot |
|
What does this PR do?
We have multiple bot commands available, but they all have different invocations. This PR consolidates everything under a
@diffusers-botcommande.g.
Fixes # (issue)
Before submitting
self-reviewskill on the diff?documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.